-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: e2e Cypress migration from ODS-2206 #3580
Test: e2e Cypress migration from ODS-2206 #3580
Conversation
…est/cypress-ods2206-pipelines
…est/cypress-ods2206-pipelines
Skipping CI for Draft Pull Request. |
…o/odh-dashboard into test/cypress-ods2206-pipelines
…est/cypress-ods2206-pipelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FedeAlonso Can you also please check this test against the latest ODH Nightly build? The test also currently takes 4 minutes to execute, is there any way that time can be improved? Or is there any type of splitting that can be done?
.../cypress/cypress/tests/e2e/dataSciencePipelines/createRunDeletePipelineCustomPipMirror.cy.ts
Show resolved
Hide resolved
This test takes 4 minutes because it's a quite complete one. Also, running a pipeline always takes time, and in this case we need to have a more complex one, as it's used also for disconnected testing. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
==========================================
- Coverage 85.15% 85.13% -0.02%
==========================================
Files 1395 1395
Lines 32041 32041
Branches 8979 8979
==========================================
- Hits 27283 27279 -4
- Misses 4758 4762 +4 see 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manosnoam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-16476
Description
Cypress Smoke test from ODS-CI "ODS-2206"
Title: Verify User Can Create, Run and Delete A DS Pipeline From DS Project Details Page Using Custom Pip Mirror
This test Run an Iris DSP, and then deletes the DSP version and the DSP. All just by using the UI.
It has also the particularity that the PIP server (or mirror) is configured by env variables, so it can run in a disconnected environment.
How Has This Been Tested?
Locally against a live cluster.
Command:
$ npx cypress run --spec "**/createRunDeletePipelineCustomPipMirror.cy.ts" --browser chrome
Test Impact
Addition of a new e2e Cypress test
Request review criteria:
Self checklist (all need to be checked):
After the PR is posted & before it merges:
main